Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for date_spine macro, and sub macros #943

Merged
merged 9 commits into from
Oct 11, 2023

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Sep 25, 2023

resolves dbt-labs/dbt-core#8172

Problem

In dbt-labs/dbt-core#8172 we moved the date_spine macro and sub macros from dbt-utils to dbt-core. As such we should begin testing these macros to ensure they work properly on this adapter.

Solution

Begin running the tests for the date_spine macro and sub macros

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@QMalcolm QMalcolm added the Skip Changelog Skips GHA to check for changelog file label Sep 25, 2023
@QMalcolm QMalcolm requested a review from a team as a code owner September 25, 2023 19:51
@cla-bot cla-bot bot added the cla:yes label Sep 25, 2023
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integration test issue:

01:25:51  1 of 2 ERROR creating sql view model test16969875427802607843_test_utils.test_get_intervals_between  [ERROR in 1.73s]
01:25:51  2 of 2 SKIP test assert_equal_test_get_intervals_between_intervals__expected ... [SKIP]
01:25:51  
01:25:51  Finished running 1 view model, 1 test in 0 hours 0 minutes and 4.99 seconds (4.99s).
01:25:51  
01:25:51  Completed with 1 error and 0 warnings:
01:25:51  
01:25:51    Database Error in model test_get_intervals_between (models/test_get_intervals_between.sql)
  Invalid datetime string "09/12/2023"

@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) October 11, 2023 18:24
@colin-rogers-dbt colin-rogers-dbt merged commit b06414f into main Oct 11, 2023
22 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the qmalcolm--date-spine-utils-testing branch October 11, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2855] [Feature] dbt_utils.date_spine should be added to core given new MetricFlow requirements
3 participants