-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for date_spine
macro, and sub macros
#943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
approved these changes
Oct 10, 2023
colin-rogers-dbt
previously requested changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integration test issue:
01:25:51 1 of 2 ERROR creating sql view model test16969875427802607843_test_utils.test_get_intervals_between [ERROR in 1.73s]
01:25:51 2 of 2 SKIP test assert_equal_test_get_intervals_between_intervals__expected ... [SKIP]
01:25:51
01:25:51 Finished running 1 view model, 1 test in 0 hours 0 minutes and 4.99 seconds (4.99s).
01:25:51
01:25:51 Completed with 1 error and 0 warnings:
01:25:51
01:25:51 Database Error in model test_get_intervals_between (models/test_get_intervals_between.sql)
Invalid datetime string "09/12/2023"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#8172
Problem
In dbt-labs/dbt-core#8172 we moved the
date_spine
macro and sub macros from dbt-utils to dbt-core. As such we should begin testing these macros to ensure they work properly on this adapter.Solution
Begin running the tests for the
date_spine
macro and sub macrosChecklist