From b46cac1a9cb386c258930586d23b9f91b9b93507 Mon Sep 17 00:00:00 2001 From: Dave Connors Date: Sun, 19 Mar 2023 15:11:19 -0500 Subject: [PATCH 1/4] add negative test case --- .../tests/adapter/utils/fixture_split_part.py | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py b/tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py index 7fc70e5bf54..244fbdb7464 100644 --- a/tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py +++ b/tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py @@ -1,9 +1,9 @@ # split_part -seeds__data_split_part_csv = """parts,split_on,result_1,result_2,result_3 -a|b|c,|,a,b,c -1|2|3,|,1,2,3 -,|,,, +seeds__data_split_part_csv = """parts,split_on,result_1,result_2,result_3,result_4 +a|b|c,|,a,b,c,c +1|2|3,|,1,2,3,3 +,|,,,, """ @@ -34,6 +34,14 @@ {{ split_part('parts', 'split_on', 3) }} as actual, result_3 as expected +from data + +union all + +select + {{ split_part('parts', 'split_on', -1) }} as actual, + result_4 as expected + from data """ From ae059cd61d736e6c62eee175db3de61af9e25fd0 Mon Sep 17 00:00:00 2001 From: Dave Connors Date: Mon, 20 Mar 2023 15:26:49 -0500 Subject: [PATCH 2/4] changie --- .changes/unreleased/Fixes-20230319-151533.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changes/unreleased/Fixes-20230319-151533.yaml diff --git a/.changes/unreleased/Fixes-20230319-151533.yaml b/.changes/unreleased/Fixes-20230319-151533.yaml new file mode 100644 index 00000000000..d2786fb04e2 --- /dev/null +++ b/.changes/unreleased/Fixes-20230319-151533.yaml @@ -0,0 +1,6 @@ +kind: Fixes +body: add negative part_number arg for split part macro +time: 2023-03-19T15:15:33.7376-05:00 +custom: + Author: dave-connors-3 + Issue: "615" From 6e5370d532fdc26197fc345cdf52c3c752c9b907 Mon Sep 17 00:00:00 2001 From: Dave Connors Date: Mon, 20 Mar 2023 15:26:49 -0500 Subject: [PATCH 3/4] add negative test case --- .../tests/adapter/utils/fixture_split_part.py | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py b/tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py index 7fc70e5bf54..244fbdb7464 100644 --- a/tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py +++ b/tests/adapter/dbt/tests/adapter/utils/fixture_split_part.py @@ -1,9 +1,9 @@ # split_part -seeds__data_split_part_csv = """parts,split_on,result_1,result_2,result_3 -a|b|c,|,a,b,c -1|2|3,|,1,2,3 -,|,,, +seeds__data_split_part_csv = """parts,split_on,result_1,result_2,result_3,result_4 +a|b|c,|,a,b,c,c +1|2|3,|,1,2,3,3 +,|,,,, """ @@ -34,6 +34,14 @@ {{ split_part('parts', 'split_on', 3) }} as actual, result_3 as expected +from data + +union all + +select + {{ split_part('parts', 'split_on', -1) }} as actual, + result_4 as expected + from data """ From 03836046a31dc0da8b16bc5210d52481fb2d9218 Mon Sep 17 00:00:00 2001 From: Dave Connors Date: Mon, 20 Mar 2023 15:26:49 -0500 Subject: [PATCH 4/4] update changie --- .changes/unreleased/Fixes-20230319-151533.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changes/unreleased/Fixes-20230319-151533.yaml b/.changes/unreleased/Fixes-20230319-151533.yaml index d2786fb04e2..babed815b34 100644 --- a/.changes/unreleased/Fixes-20230319-151533.yaml +++ b/.changes/unreleased/Fixes-20230319-151533.yaml @@ -1,5 +1,5 @@ kind: Fixes -body: add negative part_number arg for split part macro +body: add negative part_number argument for split part macro time: 2023-03-19T15:15:33.7376-05:00 custom: Author: dave-connors-3