add saved queries and exports to latest #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joellabes
requested changes
May 8, 2024
| "type", | ||
| "type_params" | ||
| ], | ||
| "required": ["name", "label", "type", "type_params"], |
There was a problem hiding this comment.
I assume that these are because your formatting rules are different to what we normally use? They should be able to look at the config in the .vscode settings dir (or whatever it is) to get the style guide
| "type": "string" | ||
| } | ||
| }, | ||
| "additionalProperties": true |
There was a problem hiding this comment.
I think this breaks autocomplete or something? So i lean towards being false and we keep up to date. Without evidence, it's a weak opinion weakly held.
| "$ref": "#/$defs/array_of_strings" | ||
| }, | ||
| "where": { | ||
| "$ref": "#/$defs/array_of_strings" |
There was a problem hiding this comment.
I wonder if it's worth checking with a regex match for {{ Dimension for a lot of these, because it feels like a common mistake mode to just provide the name of the dim without the wrapper. (related)
joellabes
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #126
This PR adds support for SQEs for latest version of dbt. I used the docs here to guide implementation.
Two areas for discussion that i don't feel strongly about:
cacheas an available value in exports'export_asfield based on the docs saying "coming soon", but I am very willing to remove it until it's actually available .additionalProperties: Truefor export configs assuming that there will be more configs over time. I can make this more restrictive if we wantsorry for the unintentional whitespace edits 😅