Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the schema for SMs and metrics, remove from project yml schema #85

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

dave-connors-3
Copy link
Contributor

this updates the schemata for the new metric spec in 1.6.

per @Jstein77 there are no configs for semantic models or metrics, so we removed them as top level objects in dbt_project.yml

Copy link
Collaborator

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved without extensive review but i trust you (and the CI)!

@dave-connors-3
Copy link
Contributor Author

@Jstein77 any objections to merging this one?

Copy link
Contributor

@Jstein77 Jstein77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dave-connors-3 dave-connors-3 merged commit 16dc365 into main Aug 14, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants