Add test to restore transactions behavior. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VersusFacit
force-pushed
the
ADAP-23/add_test_for_PR_9682_in_core
branch
2 times, most recently
from
826b640
to
1f3ff09
Compare
VersusFacit
force-pushed
the
ADAP-23/add_test_for_PR_9682_in_core
branch
from
1f3ff09
to
8125ef9
Compare
|
All the test failures look related to (#21). Once that PR is merged and this is updated from |
|
@mikealfare Still getting hurt by dependency collisions. Is there something specific to this repo's requirements I can edit to fix for merge? |
mikealfare
requested changes
Mar 20, 2024
pyproject.toml
Outdated
| @@ -51,7 +51,7 @@ path = "dbt/adapters/postgres/__version__.py" | |||
|
|
|||
| [tool.hatch.envs.default] | |||
| dependencies = [ | |||
| "dbt-adapters @ git+https://github.com/dbt-labs/dbt-adapters.git", | |||
| "dbt-adapters @ git+https://github.com/dbt-labs/dbt-adapters.git@ADAP-108/fix_renamed_relations_for_1.8", | |||
There was a problem hiding this comment.
Adding a blocking change to make sure we don't accidentally merge this.
mikealfare
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #23
Added a test.
Checklist