Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release internal workflow #36

Merged
merged 13 commits into from
Mar 26, 2024
Merged

Add release internal workflow #36

merged 13 commits into from
Mar 26, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Mar 20, 2024 •
edited
Loading

Problem

We need a workflow that calls the internal build release workflow found here.

Solution

This PR adds the file and documents the what/how/why.

image

Proof of calling unit/integration tests and build completing.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Mar 20, 2024
@VersusFacit
Copy link
Contributor Author

I also need to change the reusable workflow to point to the main branch when the time comes.

@VersusFacit VersusFacit force-pushed the add_release_internal_workflow branch from 8c30ebe to 61910ab Compare March 21, 2024 02:20
emmyoop
emmyoop previously approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but same comments as dbt-labs/dbt-redshift#735

@VersusFacit VersusFacit force-pushed the add_release_internal_workflow branch from ce282bc to d632075 Compare March 26, 2024 19:55
@VersusFacit
Finalize postgres job.
a2d0c18 
Adjust param name and nix env var.
@VersusFacit VersusFacit force-pushed the add_release_internal_workflow branch from d632075 to a2d0c18 Compare March 26, 2024 19:57
mikealfare
mikealfare previously approved these changes Mar 26, 2024
View reviewed changes
@VersusFacit
Copy link
Contributor Author

Clean release job ran on latest sha. Out it goes!

@VersusFacit VersusFacit merged commit ee3da67 into main Mar 26, 2024
23 checks passed
@VersusFacit VersusFacit deleted the add_release_internal_workflow branch March 26, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@emmyoop emmyoop emmyoop left review comments

@mikealfare mikealfare mikealfare left review comments

Assignees

@VersusFacit VersusFacit

Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VersusFacit @emmyoop @mikealfare @colin-rogers-dbt