Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pull requests depending on branch in dbt-adapters are not fully working #43

Closed
2 tasks done
dbeatty10 opened this issue Apr 3, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Apr 3, 2024

Is this a new bug?

  • I believe this is a new bug
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

It's tricky to have a PR in dbt-postgres that depends on a branch in dbt-adapters and allows all CI checks to execute.

See internal slack for initial context: https://dbt-labs.slack.com/archives/C034EV1RH4Z/p1712161174778999?thread_ts=1711994615.204219&cid=C034EV1RH4Z

Expected Behavior

There should be a mechanism with a similar effect as bc0b179 that allows for (temporarily) using a dev branch in dbt-adapters for testing purposes.

Steps To Reproduce

No response

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-postgres:

Additional Context

Here's an example:

#39 needs the branch from dbt-labs/dbt-adapters#135 in order to do its testing.

@dbeatty10 dbeatty10 added bug Something isn't working triage and removed triage labels Apr 3, 2024
@colin-rogers-dbt
Copy link
Contributor

Work needed: Update pyproject.toml and hatch to load from a set of customizable dev requirement

@dbeatty10
Copy link
Contributor Author

Here's the exact changes I needed to make: bc0b179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants