Add test for ensuring bad incremental strategies get validated/caught #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR requires dbt-labs/dbt-adapters#331 to be merged first. That is because the workflow will fail here until the changes of dbt-labs/dbt-adapters#331 are available on the main branch of dbt-adapters. |
…rs dependencies This is necessary because the changes we are making in dbt-adapters via dbt-labs/dbt-adapters#331 only get tested when run with an adapter. So this branch on dbt-postgres is not just for ensuring the test is run, but also proof for the open PR in dbt-adapters that the tests work. To show that though, we have to update the dependencies to temporarily point at the dbt-adapters branch that has the work (because the work hasn't been merged to main yet)
mikealfare
approved these changes
Oct 18, 2024
…s-adapters dependencies" This reverts commit 2d62842.
mikealfare
deleted the
qmalcolm--159-always-ensure-valid-incremental_strategy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #159
Problem
dbt-labs/dbt-adapters#331 added a new test to dbt-adapters. We should also run it in dbt-postgres
Solution
Running the test in dbt-postgres
Checklist