Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tests that are covered in dbt-core #162

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove tests that are covered in dbt-core #162

merged 1 commit into from
Oct 16, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We carried over too many integration tests from dbt-core when we split dbt-postgres into its own repo.

Solution

Delete the tests in dbt-postgres; they should remain in dbt-core.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Oct 16, 2024
@mikealfare mikealfare requested a review from a team as a code owner October 16, 2024 22:28
@cla-bot cla-bot bot added the cla:yes label Oct 16, 2024
@mikealfare mikealfare merged commit 20cdf8f into main Oct 16, 2024
19 of 21 checks passed
@mikealfare mikealfare deleted the remove-duplicative-tests branch October 16, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikealfare