Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testing migration #21

Merged
merged 14 commits into from
Feb 28, 2024
Merged

Fix testing migration #21

merged 14 commits into from
Feb 28, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Feb 22, 2024 •
edited
Loading

Problem

See dbt-labs/dbt-adapters#102.

Solution

See dbt-labs/dbt-adapters#102.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Feb 22, 2024
@mikealfare mikealfare added pre-regression Regression not yet in a stable release Skip Changelog labels Feb 22, 2024
@mikealfare mikealfare requested a review from a team February 22, 2024 15:34
@mikealfare mikealfare mentioned this pull request Feb 22, 2024
Merged
4 tasks
@mikealfare mikealfare marked this pull request as ready for review February 22, 2024 17:56
@mikealfare mikealfare linked an issue Feb 27, 2024 that may be closed by this pull request
[Feature] Implement adapter tests in dbt-postgres #4
Closed
3 tasks
@mikealfare mikealfare mentioned this pull request Feb 27, 2024
Merged
4 tasks
mikealfare added a commit that referenced this pull request Feb 27, 2024
@mikealfare
Remove saved query tests, they belong in dbt-core (#26)
71102f8 
This PR only removed test cases. Failed tests are resolved via #21.
@mikealfare mikealfare merged commit c2e7104 into main Feb 28, 2024
9 checks passed
@mikealfare mikealfare deleted the fix-testing-migration branch February 28, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt left review comments

Assignees

@mikealfare mikealfare

Labels
pre-regression Regression not yet in a stable release Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Implement adapter tests in dbt-postgres
2 participants
@mikealfare @colin-rogers-dbt