swap back to __version__.py #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
reviewed
Jan 31, 2024
CONTRIBUTING.md
Outdated
| @@ -86,6 +86,8 @@ will be reflected in the virtual environment immediately. | |||
| `dbt-postgres` contains [unit](https://github.com/dbt-labs/dbt-postgres/tree/main/tests/unit) | |||
| and [functional](https://github.com/dbt-labs/dbt-postgres/tree/main/tests/functional) tests. | |||
|
|
|||
| To install test dependencies run: `pip install -e ".[test]"` | |||
There was a problem hiding this comment.
We decided to specifically not advertise that you could do this, and provide instructions just for hatch. Obviously that didn't happen at all here, but I don't think we should add this. Whether it's in this PR, or a separate docs one, we should update this file to be hatch-centric.
CONTRIBUTING.md
Outdated
| @@ -74,7 +74,7 @@ Rather than forking `dbt-labs/dbt-postgres`, use `dbt-labs/dbt-postgres` directl | |||
| [Setting up an environment](https://github.com/dbt-labs/dbt-core/blob/HEAD/CONTRIBUTING.md#setting-up-an-environment) | |||
| 3. Install `dbt-postgres` and development dependencies in the virtual environment | |||
| ```shell | |||
| pip install -e .[dev] | |||
| pip install -e "".[dev]"" | |||
There was a problem hiding this comment.
Double double quotes doesn't look right here.
colin-rogers-dbt
commented
Feb 1, 2024
| @@ -1,34 +0,0 @@ | |||
| from dbt.tests.util import run_dbt | |||
There was a problem hiding this comment.
So doesn't look like any adapter implements these tests and they're really covering dbt-core functionality.
We will test this via the persist_docs tests defined in dbt-tests-adapter in #4
McKnight-42
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
Solution
Checklist