Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace string type with api call #474

Conversation

mweso-softserve
Copy link
Contributor

Creates a macro that redefine type_string for models in dbt_project_evaluator package. No need to override it for all models in a project anymore when using package.

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Closes #469

Description & motivation

This implementation replaces type_string() macro which does't work for redshift for tables defined in the way it was implemented in dbt-project-evaluastor with api.Column.string_type(600)

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

I tested that on a local version of this package without dispatcher configuration.

Michał Wesołowski added 2 commits July 3, 2024 10:26
…y models in dbt_project_evaluator package. No need to override it for all models in a project anymore when using package.
@b-per
Copy link
Collaborator

b-per commented Aug 19, 2024

Closed with #475

@b-per b-per closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redshift__type_string overwrite is causing all existing models to be marked as modified
2 participants