Fix print_dbt_project_evaluator_issues for BigQuery
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix table reference for BigQuery compatibility
tomwphillips
requested review from
graciegoheen,
dave-connors-3 and
b-per
as code owners
b-per
requested changes
Oct 3, 2024
| @@ -33,7 +33,7 @@ | |||
| {% set db_schema = model_database ~ "." ~ model_schema if model_database else model_schema %} | |||
|
|
|||
| {% set sql_statement %} | |||
| select * from {{db_schema}}.{{name_model_checked}} | |||
| select * from {{ model_details['relation_name'] }} | |||
There was a problem hiding this comment.
I think that we can use the . notation here and remove the variables from above as they are no longer needed.
Suggested change
| select * from {{ model_details['relation_name'] }} | |
| select * from {{ model_details.relation_name }} |
There was a problem hiding this comment.
Yes, you're absolutely right. Fixed that.
…ot-notation Remove unused vars and use dot notation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
Link to Issue
Closes #502.
Description & motivation
The
print_dbt_project_evaluator_issuesmacro doesn't reference the resource correctly on BigQuery. Specifically, it misses the backticks inselect ... fromproject.dataset.table``. This PR fixes it.Unsure how to test this without re-working the macro quite substantially. AFAICT, no existing tests either. Open to discussion.
Integration Test Screenshot
See attached logs:
Checklist