Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source freshness to the list #504

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add source freshness to the list #504

wants to merge 1 commit into from

Conversation

coastlines
Copy link

@coastlines coastlines commented Oct 4, 2024 •
edited
Loading

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Description & motivation

documentation update.

fct_sources_without_freshness is one of the warnings used in the coalesce project explorer workshop but is missing from the list of rules in the documentation. The description exists under tests, it's only missing from the list. It's the first warning listed so ideally we can make this change before the workshop.

Integration Test Screenshot

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@coastlines
Add source freshness to the list
a7e4b71 
fct_sources_without_freshness is used in the coalesce workshop but is missing from the list. it's the first error listed, so it would be best if it could be found in the docs.
@coastlines coastlines added the documentation Improvements or additions to documentation label Oct 4, 2024
@coastlines coastlines marked this pull request as ready for review October 4, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen Awaiting requested review from graciegoheen graciegoheen is a code owner

@dave-connors-3 dave-connors-3 Awaiting requested review from dave-connors-3 dave-connors-3 is a code owner

@b-per b-per Awaiting requested review from b-per b-per is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coastlines