Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-1093] [Feature] Run integration tests against all supported python versions #970

Closed
3 tasks done
colin-rogers-dbt opened this issue Jan 10, 2024 · 2 comments
Closed
3 tasks done
Labels
enhancement New feature or request Stale triage

Comments

@colin-rogers-dbt
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Follow on to migrating to GHA+dagger we want to be able to run our functional tests against all supported python versions.

To do this we need to add:

  • update run_dbt_spark_tests.py to accept the python version as an arg and use that to choose the right base image to test against
  • update github actions integration.yml to pass the arg to the test script.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@colin-rogers-dbt colin-rogers-dbt added enhancement New feature or request triage labels Jan 10, 2024
@github-actions github-actions bot changed the title [Feature] Run integration tests against all supported python versions [ADAP-1093] [Feature] Run integration tests against all supported python versions Jan 10, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 9, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale triage
Projects
None yet
Development

No branches or pull requests

1 participant