From ab155ebdf878e025a8c18757ec49ec31dcf42f9c Mon Sep 17 00:00:00 2001 From: Michelle Ark Date: Sun, 19 Nov 2023 12:44:28 -0500 Subject: [PATCH 1/3] add tests for --empty flag --- dev-requirements.txt | 4 ++-- tests/functional/adapter/empty/test_empty.py | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 tests/functional/adapter/empty/test_empty.py diff --git a/dev-requirements.txt b/dev-requirements.txt index a520f1504..0751dc93e 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -1,7 +1,7 @@ # install latest changes in dbt-core # TODO: how to automate switching from develop to version branches? -git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core -git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter +git+https://github.com/dbt-labs/dbt-core.git@dry-run-flag#egg=dbt-core&subdirectory=core +git+https://github.com/dbt-labs/dbt-core.git@dry-run-flag#egg=dbt-tests-adapter&subdirectory=tests/adapter # if version 1.x or greater -> pin to major version # if version 0.x -> pin to minor diff --git a/tests/functional/adapter/empty/test_empty.py b/tests/functional/adapter/empty/test_empty.py new file mode 100644 index 000000000..1ea2c8866 --- /dev/null +++ b/tests/functional/adapter/empty/test_empty.py @@ -0,0 +1,5 @@ +from dbt.tests.adapter.empty.test_empty import BaseTestEmpty + + +class TestSparkEmpty(BaseTestEmpty): + pass From 4f67ace9f981fce96e3cbeadb136778a1519c748 Mon Sep 17 00:00:00 2001 From: Michelle Ark Date: Sun, 19 Nov 2023 13:20:57 -0500 Subject: [PATCH 2/3] changelog entry --- .changes/unreleased/Under the Hood-20231119-132050.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changes/unreleased/Under the Hood-20231119-132050.yaml diff --git a/.changes/unreleased/Under the Hood-20231119-132050.yaml b/.changes/unreleased/Under the Hood-20231119-132050.yaml new file mode 100644 index 000000000..61c7f8ab8 --- /dev/null +++ b/.changes/unreleased/Under the Hood-20231119-132050.yaml @@ -0,0 +1,6 @@ +kind: Under the Hood +body: Add tests for --empty flag +time: 2023-11-19T13:20:50.076459-05:00 +custom: + Author: michelleark + Issue: "949" From 10432d70ed6fb18150ed6d4fc3e115289a4ab484 Mon Sep 17 00:00:00 2001 From: Michelle Ark Date: Fri, 1 Dec 2023 13:51:30 -0500 Subject: [PATCH 3/3] restore dev-requirements --- dev-requirements.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-requirements.txt b/dev-requirements.txt index 0751dc93e..a520f1504 100644 --- a/dev-requirements.txt +++ b/dev-requirements.txt @@ -1,7 +1,7 @@ # install latest changes in dbt-core # TODO: how to automate switching from develop to version branches? -git+https://github.com/dbt-labs/dbt-core.git@dry-run-flag#egg=dbt-core&subdirectory=core -git+https://github.com/dbt-labs/dbt-core.git@dry-run-flag#egg=dbt-tests-adapter&subdirectory=tests/adapter +git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core +git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter # if version 1.x or greater -> pin to major version # if version 0.x -> pin to minor