Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flake8 config now properly excluding tests #989

Closed
wants to merge 1 commit into from

Conversation

danphenderson
Copy link

Problem

The flake8 config is ignoring test, which doesn't exist

Solution

It should ignore tests, or maybe the exclude line should be removed.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@danphenderson danphenderson requested a review from a team as a code owner February 21, 2024 20:40
Copy link

cla-bot bot commented Feb 21, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: danphenderson.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@danphenderson
Copy link
Author

Sorry for spamming. I will follow the rules.. I was trying to be quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant