Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable quoting column names for unpivot macro #216

Closed
ghost opened this issue Apr 30, 2020 · 4 comments · Fixed by #792
Closed

Enable quoting column names for unpivot macro #216

ghost opened this issue Apr 30, 2020 · 4 comments · Fixed by #792
Labels
enhancement New feature or request quoting Issues related to quoting behavior

Comments

@ghost
Copy link

ghost commented Apr 30, 2020

I have a table whose column names are quoted, like "BX 759 - long column name".

When I try to unpivot this table, the column names fetched don't contain quotes and the macro doesn't put the quotes in them, thus the macro fails.
m-01101101 added a commit to m-01101101/dbt-utils that referenced this issue Apr 9, 2021
@m-01101101
Update unpivot.sql
f69d89c 
## Context

Related to [issue-216](dbt-labs#216)
@GtheSheep GtheSheep mentioned this issue Jul 26, 2022
Closed
16 tasks
error418 added a commit to error418/dbt-utils that referenced this issue May 9, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
a0e216f 
fixes dbt-labs#216
@error418 error418 mentioned this issue May 9, 2023
Merged
13 tasks
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
876fba7 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
32ccf3d 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
2fb5ea9 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
74fef10 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
3f69329 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
7bf35b6 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
a6e0f53 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
ce71b80 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
605dcaa 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 15, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
d2de2de 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 16, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
9f0ff03 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 16, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
97a00ed 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 16, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
bcb1b1f 
fixes dbt-labs#216
error418 added a commit to error418/dbt-utils that referenced this issue May 17, 2023
@error418
feat(unpivot): add quote identifier parameter to unpivot macro
03467be 
fixes dbt-labs#216
@github-actions
Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 23, 2023
@github-actions
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
@error418
Copy link
Contributor

PR #792 provides a fix for this issue

@dbeatty10 dbeatty10 added bug Something isn't working and removed Stale labels Apr 18, 2024
@dbeatty10 dbeatty10 reopened this Apr 18, 2024
@dbeatty10 dbeatty10 added the quoting Issues related to quoting behavior label May 13, 2024
@dbeatty10 dbeatty10 changed the title Unpivot macro doesn't quote column name unpivot macro doesn't quote column name May 13, 2024
@dbeatty10
Copy link
Contributor

Since this is to unpivot as #135 was for pivot, I'm updating from a bug to a feature request.

@dbeatty10 dbeatty10 removed the bug Something isn't working label Jun 27, 2024
@dbeatty10 dbeatty10 added the enhancement New feature or request label Jun 27, 2024
@dbeatty10 dbeatty10 changed the title unpivot macro doesn't quote column name Enable quoting column names for unpivot macro Jun 27, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2024
@error418 @dbeatty10
Add quote_identifiers parameter to unpivot to handle case-sensiti…
9237ba9 
…ve column names (#792)

* feat(unpivot): add quote identifier parameter to unpivot macro

fixes #216

* Changelog will be updated as part of release process

* Enable test for unpivoting quoted columns for Redshift

* Fix warning related to `tests:` -> `data_tests:`

* Simplify the case-sensitive unpivot test model

* Add a newline for consistency

* Use mixed-case column names for all columns

---------

Co-authored-by: Doug Beatty <doug.beatty@dbtlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request quoting Issues related to quoting behavior
Projects
None yet
Milestone
No milestone
2 participants
@error418 @dbeatty10