Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed fewer_rows_than and equal_rowcount macros #746

Conversation

damian3031
Copy link

Fixed fewer_rows_than and equal_rowcount macros to work with warehouses which do not support lateral column aliasing

resolves #744

This is a:

  • bug fix with no breaking changes

Checklist

  • I have verified that these changes work locally on the following warehouses:
    • Trino
  • I have added an entry to CHANGELOG.md

…es which do not support lateral column aliasing
@damian3031 damian3031 force-pushed the fix-fewer_rows_than-and-equal_rowcount branch from ab48691 to dd1bbb8 Compare December 15, 2022 22:04
@joellabes
Copy link
Contributor

joellabes commented Dec 16, 2022

As discussed on the issue, we can't merge this right now, but will get back to you once we've dug into it more in the new year

@github-actions
Copy link

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 19, 2023
@github-actions
Copy link

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

equal_rowcount, fewer_rows_than macros don't work on Trino due to lateral column aliasing
2 participants