Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #848 (not_constant fails within groups with 1 element) #849

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for #848 (not_constant fails within groups with 1 element) #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74744d3
Fix for #848 (not_constant fails within groups with 1 element)
igor-lobanov-maersk Oct 18, 2023
a4bbec1
Update CHANGELOG.md
igor-lobanov-maersk Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
* Improve the performance of the `at_least_one` test by pruning early. This is especially helpful when running against external tables. By @joshuahuntley in https://github.com/dbt-labs/dbt-utils/pull/775
## Fixes
* Fix legacy links in README by @dbeatty10 in https://github.com/dbt-labs/dbt-utils/pull/796
* Fixed false positive in not_constant test when using groupings and a grouping has only one row by @igor-lobanov-maersk https://github.com/dbt-labs/dbt-utils/issues/848

# dbt utils v1.1.0
## What's Changed
Expand Down
2 changes: 1 addition & 1 deletion macros/generic_tests/not_constant.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ from {{ model }}
{{groupby_gb_cols}}

having count(distinct {{ column_name }}) = 1

and count(1) > 1

{% endmacro %}