Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We currently don't support unit testing models that use the materialized view materialization #5986

Merged
merged 6 commits into from
Aug 29, 2024
Merged

We currently don't support unit testing models that use the materialized view materialization #5986

merged 6 commits into from
Aug 29, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Aug 28, 2024 •
edited
Loading

Preview

What are you changing in this pull request and why?

We currently don't support unit testing models that use the materialized view materialization=

See dbt-labs/dbt-postgres#111

Checklist

@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 29, 2024 4:42pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Aug 28, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review August 28, 2024 18:38
@dbeatty10 dbeatty10 requested a review from a team as a code owner August 28, 2024 18:38
graciegoheen
graciegoheen approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you doug

mirnawong1
mirnawong1 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @dbeatty10 this looks good to me, thanks for opening! i noticed the core issue you linked was for dbt-postres so does this limitation apply to postgres only? or all adapters?

@dbeatty10
Copy link
Contributor Author

i noticed the core issue you linked was for dbt-postres so does this limitation apply to postgres only? or all adapters?

I didn't confirm myself, but my understanding is that this applies to all adapters.

Internal Slack convo here.

mirnawong1
mirnawong1 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @dbeatty10 !

matthewshaver
matthewshaver approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@matthewshaver matthewshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dbeatty10 for always being amazing!

@matthewshaver matthewshaver merged commit 9098144 into current Aug 29, 2024
10 checks passed
@matthewshaver matthewshaver deleted the dbeatty10-patch-1 branch August 29, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen graciegoheen approved these changes

@matthewshaver matthewshaver matthewshaver approved these changes

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbeatty10 @graciegoheen @matthewshaver @mirnawong1