From 6d0433eda4ac5e2e2335fc1399fcb5a1d2a0148b Mon Sep 17 00:00:00 2001 From: ericalouie Date: Tue, 2 Apr 2019 13:00:31 -0400 Subject: [PATCH 1/3] change session roll-up to be based on page_view_in_session_index --- macros/adapters/bigquery/sessions/snowplow_sessions_tmp.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/macros/adapters/bigquery/sessions/snowplow_sessions_tmp.sql b/macros/adapters/bigquery/sessions/snowplow_sessions_tmp.sql index 0f5eb21..8c92348 100644 --- a/macros/adapters/bigquery/sessions/snowplow_sessions_tmp.sql +++ b/macros/adapters/bigquery/sessions/snowplow_sessions_tmp.sql @@ -40,7 +40,7 @@ sessions_agg as ( select pv.session_id, - array_agg(pv order by pv.page_view_start) as all_pageviews + array_agg(pv order by pv.page_view_in_session_index) as all_pageviews from relevant_page_views as pv group by 1 From f0aec78401e6a351af6d101a39df9aed933c4246 Mon Sep 17 00:00:00 2001 From: ericalouie Date: Tue, 2 Apr 2019 13:37:39 -0400 Subject: [PATCH 2/3] remove timestamp cast --- macros/adapters/bigquery/pageviews/snowplow_page_views.sql | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/macros/adapters/bigquery/pageviews/snowplow_page_views.sql b/macros/adapters/bigquery/pageviews/snowplow_page_views.sql index 93386c5..c74c2b3 100644 --- a/macros/adapters/bigquery/pageviews/snowplow_page_views.sql +++ b/macros/adapters/bigquery/pageviews/snowplow_page_views.sql @@ -183,8 +183,8 @@ page_pings as ( select page_view_id, - min(timestamp(collector_tstamp)) as page_view_start, - max(timestamp(collector_tstamp)) as page_view_end, + min(collector_tstamp) as page_view_start, + max(collector_tstamp) as page_view_end, struct( max(doc_width) as doc_width, @@ -205,7 +205,7 @@ page_pings as ( array_agg(struct( event_id, event, - timestamp(collector_tstamp) as collector_tstamp, + collector_tstamp as collector_tstamp, pp_xoffset_min, pp_xoffset_max, pp_yoffset_min, From e31e6513f89a5887d2ad84b63ba4528c94cd72f3 Mon Sep 17 00:00:00 2001 From: ericalouie Date: Wed, 3 Apr 2019 10:08:29 -0400 Subject: [PATCH 3/3] change timestamp() cast to cast( as timestamp) --- macros/adapters/bigquery/pageviews/snowplow_page_views.sql | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/macros/adapters/bigquery/pageviews/snowplow_page_views.sql b/macros/adapters/bigquery/pageviews/snowplow_page_views.sql index c74c2b3..f9b63cf 100644 --- a/macros/adapters/bigquery/pageviews/snowplow_page_views.sql +++ b/macros/adapters/bigquery/pageviews/snowplow_page_views.sql @@ -183,8 +183,8 @@ page_pings as ( select page_view_id, - min(collector_tstamp) as page_view_start, - max(collector_tstamp) as page_view_end, + min(cast(collector_tstamp as timestamp)) as page_view_start, + max(cast(collector_tstamp as timestamp)) as page_view_end, struct( max(doc_width) as doc_width, @@ -205,7 +205,7 @@ page_pings as ( array_agg(struct( event_id, event, - collector_tstamp as collector_tstamp, + cast(collector_tstamp as timestamp) as collector_tstamp, pp_xoffset_min, pp_xoffset_max, pp_yoffset_min,