Merge pull request #63 from tayloramurphy/gitlab-browser-changes

Add browser columns and change Unioned CTE
dbt-labs · Jun 24, 2019 · 692938e · 692938e
2 parents 4dc4d66 + b874708
commit 692938e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/macros/adapters/default/page_views/snowplow_page_views.sql b/macros/adapters/default/page_views/snowplow_page_views.sql
@@ -248,9 +248,9 @@ prep as (
             d.device_family as device,
         {% else %}
             null::text as browser,
-            null::text as browser_name,
-            null::text as browser_major_version,
-            null::text as browser_minor_version,
+            a.br_family as browser_name,
+            a.br_name as browser_major_version,
+            a.br_version as browser_minor_version,
             null::text as browser_build_version,
             a.os_family as os,
             a.os_name as os_name,

diff --git a/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql b/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql
@@ -120,7 +120,7 @@ relevant_existing as (
     where page_view_id in (select page_view_id from relative)
 ),
 
-unioned as (
+unioned_cte as (
 
     select
         page_view_id,
@@ -179,7 +179,7 @@ merged as (
         max(relative_vmin) as relative_vmin,
         max(relative_vmax) as relative_vmax
 
-    from unioned
+    from unioned_cte
     group by 1
 
 

diff --git a/macros/adapters/default/page_views/snowplow_web_events_time.sql b/macros/adapters/default/page_views/snowplow_web_events_time.sql
@@ -81,7 +81,7 @@ relevant_existing as (
 
 ),
 
-unioned as (
+unioned_cte as (
 
     select
         page_view_id,
@@ -115,7 +115,7 @@ merged as (
         sum(pp_count) as pp_count,
         sum(time_engaged_in_s) as time_engaged_in_s
 
-    from unioned
+    from unioned_cte
     group by 1