From 26dd227462fc23e3212ee6f87a6b059f2a5204e4 Mon Sep 17 00:00:00 2001 From: "Taylor A. Murphy" Date: Fri, 21 Jun 2019 09:45:20 -0500 Subject: [PATCH 1/4] Add browser columns --- macros/adapters/default/page_views/snowplow_page_views.sql | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/macros/adapters/default/page_views/snowplow_page_views.sql b/macros/adapters/default/page_views/snowplow_page_views.sql index 1a11fef..a184130 100644 --- a/macros/adapters/default/page_views/snowplow_page_views.sql +++ b/macros/adapters/default/page_views/snowplow_page_views.sql @@ -248,9 +248,9 @@ prep as ( d.device_family as device, {% else %} null::text as browser, - null::text as browser_name, - null::text as browser_major_version, - null::text as browser_minor_version, + a.br_family as browser_name, + a.br_name as browser_major_version, + a.br_version as browser_minor_version, null::text as browser_build_version, a.os_family as os, a.os_name as os_name, From 9f7e8752651f8e01d39366ef573a0bf7db8fe19f Mon Sep 17 00:00:00 2001 From: "Taylor A. Murphy" Date: Fri, 21 Jun 2019 09:45:36 -0500 Subject: [PATCH 2/4] Change CTE name to avoid Snowflake bug --- .../default/page_views/snowplow_web_events_scroll_depth.sql | 4 ++-- .../adapters/default/page_views/snowplow_web_events_time.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql b/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql index b6293e7..abedfaf 100644 --- a/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql +++ b/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql @@ -120,7 +120,7 @@ relevant_existing as ( where page_view_id in (select page_view_id from relative) ), -unioned as ( +unioned_cte as ( select page_view_id, @@ -179,7 +179,7 @@ merged as ( max(relative_vmin) as relative_vmin, max(relative_vmax) as relative_vmax - from unioned + from unioned_cte group by 1 diff --git a/macros/adapters/default/page_views/snowplow_web_events_time.sql b/macros/adapters/default/page_views/snowplow_web_events_time.sql index 6ef5941..95eaa06 100644 --- a/macros/adapters/default/page_views/snowplow_web_events_time.sql +++ b/macros/adapters/default/page_views/snowplow_web_events_time.sql @@ -81,7 +81,7 @@ relevant_existing as ( ), -unioned as ( +unioned_cte as ( select page_view_id, @@ -115,7 +115,7 @@ merged as ( sum(pp_count) as pp_count, sum(time_engaged_in_s) as time_engaged_in_s - from unioned + from unioned_cte group by 1 From 988bdc0cee848d72c197979b2567539f0c8bea60 Mon Sep 17 00:00:00 2001 From: "Taylor A. Murphy" Date: Fri, 21 Jun 2019 09:45:20 -0500 Subject: [PATCH 3/4] Add browser columns --- macros/adapters/default/page_views/snowplow_page_views.sql | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/macros/adapters/default/page_views/snowplow_page_views.sql b/macros/adapters/default/page_views/snowplow_page_views.sql index 1a11fef..a184130 100644 --- a/macros/adapters/default/page_views/snowplow_page_views.sql +++ b/macros/adapters/default/page_views/snowplow_page_views.sql @@ -248,9 +248,9 @@ prep as ( d.device_family as device, {% else %} null::text as browser, - null::text as browser_name, - null::text as browser_major_version, - null::text as browser_minor_version, + a.br_family as browser_name, + a.br_name as browser_major_version, + a.br_version as browser_minor_version, null::text as browser_build_version, a.os_family as os, a.os_name as os_name, From e0caec80483a9fbccfca47ddde8b867769553800 Mon Sep 17 00:00:00 2001 From: "Taylor A. Murphy" Date: Fri, 21 Jun 2019 09:45:36 -0500 Subject: [PATCH 4/4] Change CTE name to avoid Snowflake bug --- .../default/page_views/snowplow_web_events_scroll_depth.sql | 4 ++-- .../adapters/default/page_views/snowplow_web_events_time.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql b/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql index b6293e7..abedfaf 100644 --- a/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql +++ b/macros/adapters/default/page_views/snowplow_web_events_scroll_depth.sql @@ -120,7 +120,7 @@ relevant_existing as ( where page_view_id in (select page_view_id from relative) ), -unioned as ( +unioned_cte as ( select page_view_id, @@ -179,7 +179,7 @@ merged as ( max(relative_vmin) as relative_vmin, max(relative_vmax) as relative_vmax - from unioned + from unioned_cte group by 1 diff --git a/macros/adapters/default/page_views/snowplow_web_events_time.sql b/macros/adapters/default/page_views/snowplow_web_events_time.sql index 6ef5941..95eaa06 100644 --- a/macros/adapters/default/page_views/snowplow_web_events_time.sql +++ b/macros/adapters/default/page_views/snowplow_web_events_time.sql @@ -81,7 +81,7 @@ relevant_existing as ( ), -unioned as ( +unioned_cte as ( select page_view_id, @@ -115,7 +115,7 @@ merged as ( sum(pp_count) as pp_count, sum(time_engaged_in_s) as time_engaged_in_s - from unioned + from unioned_cte group by 1