zx: use clap for arg parsing #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FineFindus
commented
Nov 5, 2023
FineFindus
force-pushed
the
feat/zx-args-parser
branch
3 times, most recently
from
223afd2 to
8d272dc
Compare
|
@FineFindus hey. You think you'll be able to finish this soon? |
|
It's basically done, the only two things missing are #499 being merged and the MSRV CI failing. I'm still not quite sure why, for some reason it tries to build a newer clap version than specified. Maybe a caching problem? We could try a re-run, hoping that the cache is now old enough not to be an issue-. |
FineFindus
force-pushed
the
feat/zx-args-parser
branch
2 times, most recently
from
15841a1 to
3468d59
Compare
|
Rebased the pr to the latest |
FineFindus
force-pushed
the
feat/zx-args-parser
branch
2 times, most recently
from
b432d51 to
b89f7db
Compare
zeenix
requested changes
Jan 20, 2024
FineFindus
force-pushed
the
feat/zx-args-parser
branch
2 times, most recently
from
b989419 to
8023001
Compare
Changes the command-line interface, input files are now specified with subcommands instead of arguments.
`global` arguments can be positioned in subcommands. This makes it possbile to use the argument at the end.
zeenix
force-pushed
the
feat/zx-args-parser
branch
from
8023001 to
0fe4b11
Compare
zeenix
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
zbus-xmlgento useclap. This change converts the--session,--system,--address, andfilearguments into subcommands.Builds on #499 to also add the
--split-interfacesoptions.Possible future improvements