Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatiblity between expandable-table-row and nova-sortable #4

Open
scramatte opened this issue Oct 14, 2023 · 0 comments
Open

Compatiblity between expandable-table-row and nova-sortable #4

scramatte opened this issue Oct 14, 2023 · 0 comments

Comments

@scramatte
Copy link
Contributor

scramatte commented Oct 14, 2023

Hi,

Please find my patch here
https://github.com/operativeit/nova-sortable

And for expandable-table-row I've send you a PR

What I would like to comment with you as I follow your way to minimize component overriding is if you know how can we add
draggable component programmatically.

Basically what I've done is move draggable on table tag itself, wrap each tr into tbody and append index property as it's necessary to sort list correctly. Without this property the reorder is incorrect as draggable reporta incorrect index ( it lookup to all html children including thead or any other markup).

Please take a look to the code and if you know a way to remove the last override.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant