-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Save units and calibration #354
Conversation
@pieper - I added a full set of unit tests to this. There are a bunch of identical changes to support this, but the actual change is really limited to three changes: Then, I added unit tests for all the above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - thanks 👍
🎉 This PR is included in version 0.29.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This change adds the ability to save the user calibration as well as saving the no-units calibration (there doesn't seem to be a "pixel" units right now)
The proposed format for the user calibration is: