Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generate-dictionary): update generate script to use https and regenerate source dictionary #397

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix(generate-dictionary): update generate script to use https and regenerate source dictionary #397

merged 2 commits into from
Jul 31, 2024

Conversation

craigberry1
Copy link
Contributor

@craigberry1 craigberry1 commented Jul 18, 2024 •
edited
Loading

  • Fixes issue running generate-dictionary script
  • Update source dictionary to latest version of the DICOM spec

@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for dcmjs2 ready!

Name Link
🔨 Latest commit fe7ba53
🔍 Latest deploy log https://app.netlify.com/sites/dcmjs2/deploys/66997095283b390008326260
😎 Deploy Preview https://deploy-preview-397--dcmjs2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@craigberry1
Copy link
Contributor Author

Hey @pieper are you able to take a look at this?

@craigberry1
Copy link
Contributor Author

Bump @pieper

pieper
pieper approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this 👍

Sorry for the slow response - I was away and didn't have access to github for a while.

@pieper pieper merged commit a4c5312 into dcmjs-org:master Jul 31, 2024
13 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.33.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@craigberry1
Copy link
Contributor Author

Thanks for doing this 👍

Sorry for the slow response - I was away and didn't have access to github for a while.

No problem! Thanks for getting it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieper pieper pieper approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigberry1 @pieper