-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other double as explicit value representation #399
Other double as explicit value representation #399
Conversation
…dding when reading vr from data element
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for working on this 👍 Even though it's a small file, let's put it in as a data release asset for consistency. Can you update the test, remove the dcm file and update the PR? https://github.com/dcmjs-org/data/releases/tag/od-encoding-data |
Done 👍 |
🎉 This PR is included in version 0.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add reserved 2 byte padding to
OtherDouble
read logic and read value length as 32 bit integer per spec.Specifically section 7.1.2 that states:
for VRs of AE, AS, AT, CS, DA, DS, DT, FL, FD, IS, LO, LT, PN, SH, SL, SS, ST, TM, UI, UL and US the Value Length Field is the 16-bit unsigned integer following the two byte VR Field. The value of the Value Length Field shall equal the length of the Value Field.
Meaning
OD
should be treated as:for all other VRs the 16 bits following the two byte VR Field are reserved for use by later versions of the DICOM Standard. These reserved bytes shall be set to 0000H and shall not be used or decoded. The Value Length Field is a 32-bit unsigned integer.