feat(lossless-round-trip): Implement lossless read writes #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
August 6, 2024 16:07
…rom readTag, manually apply formatting on returned Value property
… deep equals implementation and tests
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pieper
approved these changes
Aug 16, 2024
|
🎉 This PR is included in version 0.34.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #398 by implementing lossless round trip read/writes to preserve original file data when tags are unmodified
ValueRepresentation.applyFormatting_rawValueproperty on a data elementValueduring writes to determine whether to maintain original unformatted value or updateBinaryValueRepresentationfrom lossless processing by default to avoid duplicating large arrayBuffers like pixel data, but provide override mechanism viareadOptions