fix(src/test): Address lint issues + setup lint/format CI action #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
igoroctaviano
commented
Oct 15, 2024
•
igoroctaviano
commented
- Address lint issues
- Add format and ci lint action to avoid merging broken/unformatted code
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
igoroctaviano
force-pushed
the
fix/lint
branch
from
030a8d5
to
5313cbe
Compare
igoroctaviano
changed the title
igoroctaviano
changed the title
pieper
reviewed
Oct 15, 2024
| @@ -302,7 +292,7 @@ class MeasurementStatisticalProperties extends Template { | |||
| value: options.authority, | |||
| relationshipType: RelationshipTypes.HAS_PROPERTIES | |||
| }); | |||
| this.push(authorityItem); | |||
| this.push(descriptionItem); | |||
There was a problem hiding this comment.
Looks like this was a bug before and isn't part of the code formatting?
There was a problem hiding this comment.
True but I catched it through lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.