Skip to content

Commit

Permalink
Migrate to web_extra_exposed_ports (#56)
Browse files Browse the repository at this point in the history
* migrate to web_extra_exposed_ports

* Remove '.ddev/docker-compose.browsersync.yaml'

* Use force flag for disruptive operations

Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>

---------

Co-authored-by: tyler36 <7234392+tyler36@users.noreply.github.com>
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
  • Loading branch information
3 people authored Sep 5, 2024
1 parent f68e5b0 commit 5f52127
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 11 deletions.
6 changes: 6 additions & 0 deletions config.browsersync.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#ddev-generated
web_extra_exposed_ports:
- name: browsersync
container_port: 3000
http_port: 3001
https_port: 3000
10 changes: 0 additions & 10 deletions docker-compose.browsersync.yaml

This file was deleted.

5 changes: 4 additions & 1 deletion install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pre_install_actions:
fi
project_files:
- docker-compose.browsersync.yaml
- config.browsersync.yaml
- web-build/Dockerfile.ddev-browsersync
- browser-sync.js
- commands/web/browsersync
Expand All @@ -22,3 +22,6 @@ post_install_actions:
if ( test -f "$HOME/.ddev/commands/web/browsersync" ) ; then
echo "Note: '~/.ddev/commands/web/browsersync' is no longer required and can be safely removed." && exit 0
fi
#ddev-nodisplay
#ddev-description:Remove old 'docker-compose.browsersync.yaml'
if grep "#ddev-generated" $DDEV_APPROOT/.ddev/docker-compose.browsersync.yaml 2>/dev/null; then rm -f "$DDEV_APPROOT/.ddev/docker-compose.browsersync.yaml"; fi

0 comments on commit 5f52127

Please sign in to comment.