Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev symlink-project does not run automatically on ddev start as README states #66

Closed
markdorison opened this issue Jul 12, 2024 · 2 comments · Fixed by #67
Closed

ddev symlink-project does not run automatically on ddev start as README states #66

markdorison opened this issue Jul 12, 2024 · 2 comments · Fixed by #67

Comments

@markdorison
Copy link
Contributor

From the README:

ddev symlink-project. This symlinks the top level files of your project into web/modules/custom so that Drupal finds your module. This command runs automatically on every ddev start. See codebase image below.

In my testing, I have seen this not occur and I then need to run ddev symlink-project manually. Could this be a bug or maybe the documentation is out of date?

@rfay
Copy link
Member

rfay commented Jul 12, 2024

Here's how it happens, and it only happens ifvendor/autoload.php is there already:

hooks:
post-start:
- exec-host: |
if [[ -f vendor/autoload.php ]]; then
ddev symlink-project
else
exit 0
fi

IMO the else there is incorrect, and of course the symlink is not done on every start I don't think

@markdorison
Copy link
Contributor Author

That clarifies things. Thanks @rfay! I created PR #67 to update the README to include this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants