Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ddev phpmyadmin work again for Gitpod, fixes #15 #16

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jul 12, 2024

The Issue

How This PR Solves The Issue

Fixes the condition to open the correct port (I chose not to change the forwarded port from 8036 to 8037 in the docker-compose.phpmyadmin-norouter.yaml file because we only "use" HTTP ports in the cloud and it would be confusing if we forwarded the HTTPS port).

Adds a tip about preview mode in Gitpod.

Renames docker-compose.phpmyadmin-norouter.yaml to docker-compose.phpmyadmin_norouter.yaml

Manual Testing Instructions

Test with Gitpod on DDEV HEAD:

Open in Gitpod

ddev get https://github.com/ddev/ddev-phpmyadmin/tarball/20240712_stasadev_launch_gitpod
ddev restart
ddev phpmyadmin

No need to test it with Codespaces because it won't work anyway, I see we don't omit ddev-router in Codespaces, it's in my TODOs.

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay
Copy link
Member

rfay commented Jul 12, 2024

Could we change docker-compose.phpmyadmin-norouter.yaml to docker-compose.phpmyadmin_norouter.yaml while we're here?

Oddly, - sorts before all alpha, and _ sorts after all alpha.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this, thanks!

@rfay rfay merged commit 440c403 into main Jul 15, 2024
2 checks passed
@rfay rfay deleted the 20240712_stasadev_launch_gitpod branch July 15, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants