Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin phpmyadmin to 5.2.0, fixes #17 #18

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

stasadev
Copy link
Member

The Issue

phpMyAdmin was updated 9 days ago to 5.2.1, something has changed upstream.

How This PR Solves The Issue

Change the version from 5 to 5.2.0.

Manual Testing Instructions

  1. Click Open in Gitpod https://ddev.github.io/ddev-gitpod-launcher/
  2. Wait for the website to be ready.
  3. ddev get https://github.com/ddev/ddev-phpmyadmin/tarball/20240715_stasadev_pin_the_image && ddev restart
  4. Stop the workspace here https://gitpod.io/workspaces
  5. Start it again, run ddev start, it should work.

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay
Copy link
Member

rfay commented Jul 15, 2024

Does this affect you on your local on linux after doing docker pull phpmyadmin ? May not have had anything to do with gitpod?

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to reproduce the problem on macOS, trying to docker pause phpmyadmin and then restart.

I was able to reproduce it on gitpod.

This fixes it. Thanks!

@rfay rfay merged commit fd1b2b7 into main Jul 15, 2024
2 checks passed
@rfay rfay deleted the 20240715_stasadev_pin_the_image branch July 15, 2024 20:05
@stasadev
Copy link
Member Author

I was also unable to reproduce it locally on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants