Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: healthcheck makes it come up too slowly #2

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 22, 2023

The Issue

With the healthcheck test in there it was taking forever to become ready.

How This PR Solves The Issue

Remove the test from the healthcheck

Manual Testing Instructions

ddev get https://github.com/ddev/ddev-phpmyadmin/tarball/20230721_less_healthcheck
ddev restart

It shouldn't wait forever to come up after it says "router started"

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rfay rfay merged commit eb20886 into main Jul 22, 2023
2 checks passed
@rfay rfay deleted the 20230721_less_healthcheck branch July 22, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant