Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: directly expose port on 8036 when router disabled, fixes #3 #4

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 26, 2023

The Issue

How This PR Solves The Issue

  • When omit_containers[ddev-router] create a docker-compose.phpmyadmin-norouter.yaml which exposes container port 80 as localhost port 8036
  • On removal of the add-on, also remove the new file

Manual Testing Instructions

With and without omit_containers: [ddev-router] try:

ddev get https://github.com/rfay/ddev-phpmyadmin/tarball/20230725_ports
ddev restart

This should work on Gitpod and Github Codespacees

Automated Testing Overview

  • Needs test

Related Issue Link(s)

Release/Deployment Notes

@rfay rfay marked this pull request as ready for review July 27, 2023 15:45
@rfay rfay merged commit e9a3c79 into ddev:main Jul 27, 2023
2 checks passed
@rfay rfay deleted the 20230725_ports branch July 27, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant