Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you create a new version tag which is compatible with go modules? #119

Open
hkdnet opened this issue Mar 11, 2019 · 1 comment
Open

Comments

@hkdnet
Copy link

hkdnet commented Mar 11, 2019

Recently, forego has date-format tags but these tags are incompatible with go module tags.

ref: https://github.com/golang/go/wiki/Modules#modules

Modules must be semantically versioned according to semver, usually in the form v(major).(minor).(patch), such as v0.1.0, v1.2.3, or v1.5.0-rc.1. The leading v is required. If using Git, tag released commits with their versions.

I cannot get the latest version with GO111MODULE=on because recent tags, incompatible with go modules, are ignored.

$ GO111MODULE=on go mod init 
$ GO111MODULE=on go get -u github.com/ddollar/forego 
$ cat go.mod
module github.com/hkdnet/foo

go 1.12

require github.com/ddollar/forego v0.16.1 // indirect

Could you create a new version tag? I hope I can get the latest version with GO111MODULE=on.

@jeffwidman
Copy link

#128 includes switching to go modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants