Use sh instead of bash #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be rebased over the merged #117. |
There are plenty of environments without BASH, but with sh.
These could have caused problems: $!"\
- exit if directory doesn't exist - source .profile only if it exists - don't suppress stderr while doing that
Injects Makefile arg VERSION into main.Version with default value of "dev".
The output padding is based upon the longest name of processes and thus never changes at runtime so we can optimize things a bit by only creating the output formatter pattern once at startup.
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
There's already a PR for this (#117) and this incorporates that change but I found it had been taken further (and better than my own efforts) on @BIG5Concepts branch so I've pulled it in.
There's also a change to the format flags which is in PR's #112 and #120, though I haven't brought all of those PR's in, they are definitely still separate things.
I hope you can get round to looking at this as it'll bring it in to line with Foreman which made this change a while back (ddollar/foreman/pull/246).
Any problems/thoughts, just let me know.
Regards,
iain