You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You may have noticed I've been playing around with your wrapper :)
Here's a list of things I've found useful:
Pass the entire section id through context (rather than its numeric equivalent). This makes supporting custom section ids a no-brainer
Pass down rest props in Focusables. This will enable uses to disable them, for instance
Add config props to FocusableSections, just like the ones in SpatialNavigation
Let FocusableSections access the global config through context (maybe?)
Add support for all events
Rename onFocus (e.g. onFocused, making it consistent with js-spatial-navigation,) to not lose the ability to handle native focus events (after rest props are being passed down)
...
The text was updated successfully, but these errors were encountered:
acontreras89
changed the title
Accept disabled prop and pass it down to the div
Some suggestions from a use case
Dec 20, 2017
no worries @dead, I just wanted a place to write down all the enhancements I'm doing on the library. Most of them are one-liners, so they shouldn't be too hard to cherry-pick.
This list is expected to grow in the next couple of days, tho.
You may have noticed I've been playing around with your wrapper :)
Here's a list of things I've found useful:
Focusable
s. This will enable uses to disable them, for instanceFocusableSection
s, just like the ones inSpatialNavigation
FocusableSection
s access the global config through context (maybe?)onFocus
(e.g.onFocused
, making it consistent withjs-spatial-navigation
,) to not lose the ability to handle native focus events (after rest props are being passed down)The text was updated successfully, but these errors were encountered: