Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions from a use case #7

Open
acontreras89 opened this issue Dec 20, 2017 · 2 comments
Open

Some suggestions from a use case #7

acontreras89 opened this issue Dec 20, 2017 · 2 comments

Comments

@acontreras89
Copy link

acontreras89 commented Dec 20, 2017

You may have noticed I've been playing around with your wrapper :)

Here's a list of things I've found useful:

  • Pass the entire section id through context (rather than its numeric equivalent). This makes supporting custom section ids a no-brainer
  • Pass down rest props in Focusables. This will enable uses to disable them, for instance
  • Add config props to FocusableSections, just like the ones in SpatialNavigation
  • Let FocusableSections access the global config through context (maybe?)
  • Add support for all events
  • Rename onFocus (e.g. onFocused, making it consistent with js-spatial-navigation,) to not lose the ability to handle native focus events (after rest props are being passed down)
  • ...
@acontreras89 acontreras89 changed the title Accept disabled prop and pass it down to the div Some suggestions from a use case Dec 20, 2017
@dead
Copy link
Owner

dead commented Dec 21, 2017

I will implement those features when have some spare time, but PR are welcomed!
Thanks for the feedback 😄

@acontreras89
Copy link
Author

acontreras89 commented Dec 22, 2017

no worries @dead, I just wanted a place to write down all the enhancements I'm doing on the library. Most of them are one-liners, so they shouldn't be too hard to cherry-pick.

This list is expected to grow in the next couple of days, tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants