Enforce requiring all read actions (read, query, subscribe) to exist in a protocol role rule.
#813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiranCohen
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 74 74
Lines 11469 11480 +11
Branches 1652 1654 +2
=======================================
+ Hits 11322 11333 +11
Misses 141 141
Partials 6 6 ☔ View full report in Codecov by Sentry. |
csuwildcat
approved these changes
Oct 2, 2024
LiranCohen
deleted the
lirancohen/force-protocol-roles-query-subscribe-read
branch
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are some inconsistencies being able to fetch record data. If a user can only query for something, they are able to get the data if it is under the encodedData size limit, however if it is not they are unable to issue a
RecordsReadfor that record.This change forces the user to include all 3 "read" actions (read, subscribe, query) when using any one of them in a protocol role-based action rule.