Permissions Grants for `MessagesGet` #748

LiranCohen · 2024-05-30T15:54:25Z

This PR modifies MessagesGet to better suit it's use and support permissions.

MessagesGet now only supports getting a single message
- If a message has data, it will be provided via a data method similarly to ReocrdsRead
Can Grant Permissions for MessagesGet scoped
- Allows unrestricted scope (no protocol scope spcified)
- If scoped to a protocol and the message to get is a Permissions-Protocol record, it will match against the scope.
- Delete messages are matched against the protocol of the RecordsWrite they reference

codecov-commenter · 2024-05-31T19:03:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (d96caec) to head (b82212b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
+ Coverage   98.66%   98.69%   +0.02%     
==========================================
  Files          73       74       +1     
  Lines       11091    11268     +177     
  Branches     1584     1609      +25     
==========================================
+ Hits        10943    11121     +178     
+ Misses        142      141       -1     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/core/dwn-error.ts

src/core/messages-grant-authorization.ts

src/handlers/messages-get.ts

thehenrytsai

Love how it is sorta in parity with RecordsRead! Except for the name 😉.

A few small comments.

…or clarity

thehenrytsai

🐐 🚀

LiranCohen force-pushed the lirancohen/messages-get-authorization branch 2 times, most recently from 79bca89 to ab3ebf2 Compare May 31, 2024 19:00

LiranCohen force-pushed the lirancohen/messages-get-authorization branch 2 times, most recently from 812aeb4 to 25f9bd7 Compare June 4, 2024 15:37

LiranCohen force-pushed the lirancohen/messages-get-authorization branch 5 times, most recently from 9ea4b3c to 00eb5d2 Compare June 24, 2024 16:12

LiranCohen changed the base branch from main to lirancohen/events-query-permission-grants June 24, 2024 16:20

LiranCohen force-pushed the lirancohen/messages-get-authorization branch from 00eb5d2 to e15ee22 Compare June 24, 2024 16:20

Base automatically changed from lirancohen/events-query-permission-grants to main June 25, 2024 00:30

LiranCohen force-pushed the lirancohen/messages-get-authorization branch from e15ee22 to afa5590 Compare June 25, 2024 00:41

LiranCohen commented Jun 25, 2024

View reviewed changes

src/core/dwn-error.ts Show resolved Hide resolved

LiranCohen force-pushed the lirancohen/messages-get-authorization branch 2 times, most recently from a7e1e93 to a7ea85d Compare June 25, 2024 18:54

LiranCohen marked this pull request as ready for review June 25, 2024 19:08

LiranCohen requested review from mistermoe, csuwildcat and thehenrytsai as code owners June 25, 2024 19:08