Disallowed write after delete #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
mistermoe,
csuwildcat and
LiranCohen
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 98.69% 98.66% -0.03%
==========================================
Files 73 73
Lines 11269 11267 -2
Branches 1612 1611 -1
==========================================
- Hits 11122 11117 -5
- Misses 141 144 +3
Partials 6 6 ☔ View full report in Codecov by Sentry. |
csuwildcat
previously approved these changes
Aug 15, 2024
Co-authored-by: Liran Cohen <c.liran.c@gmail.com>
thehenrytsai
dismissed stale reviews from csuwildcat and LiranCohen
via
75118b6
LiranCohen
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR will follow for allowing pruning to occur following a delete without pruning.