Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'Discovering Service Endpoints' section. #78

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Remove 'Discovering Service Endpoints' section. #78

merged 1 commit into from
Nov 24, 2021

Conversation

dmitrizagidulin
Copy link
Contributor

Addresses #68.

@dmitrizagidulin dmitrizagidulin mentioned this pull request Nov 11, 2021
Open
msporny
msporny approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me a bit sad because we keep kicking this can down the road... but I agree with the reasoning to remove and add it at a separate layer later.

@dmitrizagidulin dmitrizagidulin merged commit abafd4c into main Nov 24, 2021
@dmitrizagidulin dmitrizagidulin deleted the remove-service-discovery branch November 24, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny approved these changes

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

@DRK3 DRK3 Awaiting requested review from DRK3 DRK3 is a code owner

@OR13 OR13 Awaiting requested review from OR13 OR13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitrizagidulin @msporny