Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken netlify preview functionality #132

Closed
andreslucena opened this issue Jun 26, 2023 · 1 comment
Closed

Broken netlify preview functionality #132

andreslucena opened this issue Jun 26, 2023 · 1 comment

Comments

@andreslucena
Copy link
Member

While checking out #129, I noticed that we have broken the netlify preview functionality settings in this repository.

Steps to reproduce:

  1. Create a change in any file and commit it
  2. Make a PR
  3. Wait for the netlify deployment to finish
  4. Click on "details" in the netlify preview check
  5. See that you have the same as the production website (docs.decidim.org)

We need to also change the netlify preview functionality for actually checking the change against the branch that the person making the PR in the repository. As of now it doesn't work as it's making the preview deployment against develop (the branch configured in the playbook).

This is related to #131, so the fix would be similar:

The solution would involve having two playbook configurations, improving the documentation and explaining a bit how antora works, and having two commands: npm run build and npm run prod-build or something like that.

On this case it can be a bit trickier, as we'd need to check if the base branch is for the version branches (ie v0.27), but for now we can just fix develop as it's the 90% of the PRs, and we can tackle the version branches after that.

@andreslucena
Copy link
Member Author

With the latest changes it's working. I just checked it out at #138.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant