Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add process type docs #130

Closed
wants to merge 2 commits into from

Conversation

RCheesley
Copy link
Contributor

This PR adds some documentation for the Process Types introduced with this PR and this feature request.

  • Adds Spaces > Processes > Types page
  • Adds screenshots from GitHub issue
  • Adds to global navigation

@RCheesley RCheesley marked this pull request as draft May 20, 2023 15:47
@andreslucena
Copy link
Member

Hi @RCheesley, thanks for your contribution!!

With this PR we could detect that actually the build process for local development and for the Nelify preview functionality was broken (reported at #131). Now it should work on both cases.

FYI, for other reasons (adding Crowdin support) we also moved the directory structure, (moving en to docs/en/), so you need to merge with develop branch and make adjustments accordingly.

For testing out the preview feature I opened #138 based on this branch, and you can check out how this page looks like at https://deploy-preview-138--decidim-documentation.netlify.app/en/develop/admin/spaces/assemblies/types

Feel free to retake that branch or check out my changes to see how to fix the deploy preview for this PR.

@RCheesley
Copy link
Contributor Author

@andreslucena might it be easier to just create a new PR given the changes that have happened? I'm not overly confident with dealing with merge conflicts! 🙈

@andreslucena
Copy link
Member

@andreslucena might it be easier to just create a new PR given the changes that have happened? I'm not overly confident with dealing with merge conflicts!

Yeah, they can be tricky to solve.

I've added you to the @decidim/documentation team so it's easier to work with this repository. You should have an invitation, after you accept it you should be able to retake #138 with the following commands:

git remote add upstream git@github.com:decidim/documentation.git # this can be https, depending on how you have set up git locally 
git fetch upstream
git checkout upstream/feature/processes-types
git checkout -b feature/processes-types

Let me know if that works for you!

@RCheesley
Copy link
Contributor Author

Closing in favour of #138

@RCheesley RCheesley closed this Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants