Fix handling of machine creation errors in the vsphere driver
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artbin
force-pushed
the
fix-vsphere-machine-creation-error-handling
branch
from
809ab15
to
0393b61
Compare
artbin
changed the title
artbin
changed the title
artbin
changed the title
vsphere driver
artbin
changed the title
vsphere drivervsphere driver.
artbin
changed the title
vsphere driver.vsphere driver.
artbin
changed the title
vsphere driver.vsphere driver
aleksey-su
approved these changes
Oct 22, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the
vspheredriver, creating a machine(driver.Create()) is not an atomic operation. Thedriver.Create()method creates a virtual machine and then reconfigures it. If the reconfiguration fails, theMachinecontroller will set theMachine.status.currentStatus.timeoutActive: falsefield, and theMachineresource will be stuck in theCrashLoopBackOffstate forever. To fix this bug, theMachinecontroller should set theMachine.status.currentStatus.timeoutActive: truefield, then theMachinecontroller will delete the virtual machine after thehealthTimeouttimeout(defaults to 10 minutes).Release note: