removing a terminating machine from balancing after some delay #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <mikhail.scherba@flant.com>
RomanenkoDenys
approved these changes
May 30, 2024
name212
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pr introduces a delay between starting terminating a node and removing the node from the load balancing (running ensureLoadBalancer) so that when there is a rolling update of a node group, a new node has slightly more time to get ready and start accepting traffic from the load balancer.
Without this delay, a terminating node gets excluded from balancing right after a new node appears in the cluster, but the new node still requires some extra time to start all necessary containers and pass the load balancer's health checks. At this point, some requests may be dropped.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: