fix(vd): add condition message

Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
deckhouse · Jun 27, 2024 · 32193d6 · 32193d6
1 parent 0bad9f3
commit 32193d6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/images/virtualization-artifact/pkg/controller/vd/internal/resizing.go b/images/virtualization-artifact/pkg/controller/vd/internal/resizing.go
@@ -19,6 +19,7 @@ package internal
 import (
 	"context"
 	"errors"
+	"fmt"
 
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/resource"
@@ -92,7 +93,7 @@ func (h ResizingHandler) Handle(ctx context.Context, vd *virtv2.VirtualDisk) (re
 	case -1:
 		condition.Status = metav1.ConditionFalse
 		condition.Reason = vdcondition.NotRequested
-		condition.Message = ""
+		condition.Message = fmt.Sprintf("The virtual disk size is too low: should be >= %s.", pvcSpecSize.String())
 		return reconcile.Result{}, nil
 	// Expected disk size is GREATER THAN expected pvc size: resize needed, resizing to a larger size.
 	case 1:

diff --git a/images/virtualization-artifact/pkg/controller/vd/internal/resizing_test.go b/images/virtualization-artifact/pkg/controller/vd/internal/resizing_test.go
@@ -100,11 +100,9 @@ var _ = Describe("Resizing handler Run", func() {
 
 		_, err := h.Handle(context.Background(), vd)
 		Expect(err).To(BeNil())
-		Expect(vd.Status.Conditions).To(ContainElement(metav1.Condition{
-			Type:   vdcondition.ResizedType,
-			Status: metav1.ConditionFalse,
-			Reason: vdcondition.NotRequested,
-		}))
+		resized, _ := service.GetCondition(vdcondition.ResizedType, vd.Status.Conditions)
+		Expect(resized.Status).To(Equal(metav1.ConditionFalse))
+		Expect(resized.Reason).To(Equal(vdcondition.NotRequested))
 	})
 
 	It("Resize has started (vd.spec.size > pvc.spec.size)", func() {