From 248b2ae6c7fbf6297ca0b064f2fcb4656ed5cf7b Mon Sep 17 00:00:00 2001 From: Ivan Mikheykin Date: Mon, 21 Oct 2024 17:41:02 +0300 Subject: [PATCH] refactor(vmop): change vm label from name to uid (#460) - VM name may exceed 63 characters limit on the label value - UID is more robust for the purpose to get all related VMOPs. - UID is already set for VMIP resources. Signed-off-by: Ivan Mikheykin --- .../pkg/controller/vmop/internal/lifecycle.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/images/virtualization-artifact/pkg/controller/vmop/internal/lifecycle.go b/images/virtualization-artifact/pkg/controller/vmop/internal/lifecycle.go index 38a6020c3..63ca53d1c 100644 --- a/images/virtualization-artifact/pkg/controller/vmop/internal/lifecycle.go +++ b/images/virtualization-artifact/pkg/controller/vmop/internal/lifecycle.go @@ -70,7 +70,7 @@ func (h LifecycleHandler) Handle(ctx context.Context, s state.VMOperationState) // Initialize new VMOP resource: set label with vm name, set phase to Pending and all conditions to Unknown. if changed.Status.Phase == "" { - cc.AddLabel(changed, cc.LabelVirtualMachineName, changed.Spec.VirtualMachine) + cc.AddLabel(changed, cc.LabelVirtualMachineUID, string(changed.GetUID())) changed.Status.Phase = virtv2.VMOPPhasePending // Add all conditions in unknown state. conditions.SetCondition(